Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Title is cut in tab #7312

Closed
daquinons opened this issue Feb 19, 2017 · 5 comments
Closed

Title is cut in tab #7312

daquinons opened this issue Feb 19, 2017 · 5 comments

Comments

@daquinons
Copy link

daquinons commented Feb 19, 2017

Test plan

#7316 (comment)


  • Did you search for similar issues before submitting this one? Yes

  • Describe the issue you encountered: When you open a new tab, the title in tab is half cut because it's not correctly placed.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Linux, Elementary OS Loki (Based on Ubuntu 16.04 LTS)

  • Brave Version (revision SHA): 71d8ffc (0.13.4)

  • Steps to reproduce:

    1. Open tab
  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added? Yes

  • Is this an issue in the currently released version? Yes

  • Can this issue be consistently reproduced? Yes

  • Any related issues: Title in tab is not centered #7304

@luixxiul
Copy link
Contributor

Maybe it is because that the line-height and the font-size is not properly set. @cezaraugusto can you confirm the issue on a linux distro, which has different font sets than Windows/macOS?

@cezaraugusto
Copy link
Contributor

Confirmed, thanks for reporting.

@luixxiul yes, different OSes render fonts/line-height differently. I have a quick fix.

@cezaraugusto cezaraugusto self-assigned this Feb 19, 2017
@luixxiul luixxiul added this to the 0.13.5 milestone Feb 19, 2017
@luixxiul
Copy link
Contributor

@cezaraugusto Sweet! I set the milestone. Please reset it if you postpone it to the next one, thanks.

@dividinglimits
Copy link

@cezaraugusto I am guessing the line height has an explicit unit with it, correct? if so, just remove that as its already relative to the font-size.

@cezaraugusto
Copy link
Contributor

@dividinglimits actually issue was that it didn't have one but height was declared differently for each OS. Fix was to add an unitless line-height as default and removing specific heights.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.