Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Crash reporting not enabled for Windows build #7917

Closed
srirambv opened this issue Mar 27, 2017 · 7 comments
Closed

Crash reporting not enabled for Windows build #7917

srirambv opened this issue Mar 27, 2017 · 7 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Crash reporting not enabled for Windows build

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev 61b6b6b

  • Steps to reproduce:

    1. Do a clean install of 0.14.0 preview 7
    2. Launch browser from console, doesn't show Crash reporting enabled
    3. Enable payments from settings causing browser to crash(Browser crash when Brave Payments is enabled #7911), no log shown in console
  • Actual result:
    No logs shown when browser crash due to crash reporting disabled

  • Expected result:
    Crash reporting should be enabled to capture logs for browser crash

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    7911-1

  • Any related issues:

@aekeus
Copy link
Member

aekeus commented Mar 27, 2017

cc @bridiver and @alex as this could be muon related

@darkdh
Copy link
Member

darkdh commented Mar 28, 2017

fixed by brave/muon@632be42

@luixxiul
Copy link
Contributor

Is there any good QA steps, as the original issue to cause the crash has been fixed?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Mar 29, 2017
@srirambv
Copy link
Collaborator Author

Still don't see logs in console on the RC1 build.

@NejcZdovc
Copy link
Contributor

@srirambv fix from @darkdh is included in muon 2.57.7, RC1 has muon 2.57.6

@darkdh
Copy link
Member

darkdh commented Mar 29, 2017

@luixxiul , I think just need to verify you have Crash reporting enabled shown when you start Brave from console

@srirambv
Copy link
Collaborator Author

Works fine when launched from git bash shell. Windows Command prompt still doesn't show the info

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants