This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
Restart buttons need to have some visual indication of interaction #7968
Labels
addressed-with-brave-core
Needs confirmation, but this issue may be resolved with Brave Core.
bug
design
A design change, especially one which needs input from the design team.
wontfix
Comments
alexwykoff
added
the
design
A design change, especially one which needs input from the design team.
label
Mar 29, 2017
Moving to 0.14.3. Before we can handle this, we'll need to understand what we'd like the user to experience. cc: @bradleyrichter. Do we put a modal / overlay over the UI with a spinner? |
bsclifton
added
the
needs-owner ♞
This issue is tagged for an upcoming release but has no owner.
label
Apr 4, 2017
probably a good case for a modal because heading down a new path while waiting for the restart will only cause more frustration when it closes on you mid-click/read. |
bsclifton
added
needs-owner ♞
This issue is tagged for an upcoming release but has no owner.
and removed
needs-owner ♞
This issue is tagged for an upcoming release but has no owner.
labels
Apr 7, 2017
A setTimeout might work so that we show an animation before the restart action kicks off |
NejcZdovc
added
the
help wanted
The PR/issue opener needs help to complete/report the task.
label
May 7, 2018
I can work on this! Could take me a bit to get familiar with what is going on with the code though! |
bsclifton
added
wontfix
and removed
bug/good-first-bug
help wanted
The PR/issue opener needs help to complete/report the task.
labels
Aug 13, 2018
bsclifton
added
addressed-with-brave-core
Needs confirmation, but this issue may be resolved with Brave Core.
and removed
needs-owner ♞
This issue is tagged for an upcoming release but has no owner.
labels
Aug 13, 2018
Closing as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
addressed-with-brave-core
Needs confirmation, but this issue may be resolved with Brave Core.
bug
design
A design change, especially one which needs input from the design team.
wontfix
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When choosing 'Yes' from the restart notification bar, a few seconds would pass between the click and the restart. My first impression was that I didn't click or I missed the target.
Platform (Win7, 8, 10? macOS? Linux distro?):
Discovered on OS X
Brave Version (revision SHA):
0.14.0 RC2 (b00c5d9)
Steps to reproduce:
Actual result:
On a busy system, there will be a considerable delay which makes it appear as though no user action occurred.
Expected result:
Visual feedback should let the user know they hit the target and a restart is imminent.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Not sure
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: