Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clean install fails #8444

Closed
luixxiul opened this issue Apr 23, 2017 · 2 comments
Closed

Clean install fails #8444

luixxiul opened this issue Apr 23, 2017 · 2 comments
Labels
bug dev-setup release-notes/exclude
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Clean install fails.

See: https://travis-ci.org/brave/browser-laptop/jobs/224821395#L644

npm ERR! ENOTEMPTY: directory not empty, rename '/home/travis/build/brave/browser-laptop/node_modules/.ad-block.DELETE/node_modules/bloom-filter-cpp' -> > '/home/travis/build/brave/browser-laptop/node_modules/ad-block/node_modules/bloom-filter-cpp'

This is reproduced on my local machine.

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.15.0 milestone Apr 23, 2017
@bbondy
Copy link
Member

bbondy commented Apr 23, 2017

Should be working now.

@bbondy bbondy closed this as completed Apr 23, 2017
@bbondy
Copy link
Member

bbondy commented Apr 23, 2017

It was a problem with shrinkwrap.

Solved by doing these steps:
Removed the shrinkwrap file on the root, run npm install, npm prune, npm dedupe, and then npm shrinkwrap and then it produces something valid. Committed and pushed.

@bbondy bbondy reopened this Apr 23, 2017
@bbondy bbondy closed this as completed Apr 23, 2017
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
82 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug dev-setup release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@bbondy @luixxiul