This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
eth-wallet: password flow based on the hash stored on the fs #15027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
reviewed
Aug 15, 2018
app/ethWallet-geth.js
Outdated
|
|
||
| ipcMain.on('eth-wallet-store-password-hash', (e, str) => { | ||
| bcrypt.genSalt(10, (err, salt) => { | ||
| if (err) { |
There was a problem hiding this comment.
In any case we are checking for if (err), let's go ahead and output it via console.error
Slava
force-pushed
the
eth-wallet-password
branch
from
535e858 to
e16edc8
Compare
ryanml
reviewed
Aug 15, 2018
diracdeltas
reviewed
Aug 15, 2018
app/ethWallet-geth.js
Outdated
| }) | ||
|
|
||
| ipcMain.on('eth-wallet-store-password-hash', (e, str) => { | ||
| bcrypt.genSalt(10, (err, salt) => { |
There was a problem hiding this comment.
10 is kind of a small factor. did you benchmark this?
There was a problem hiding this comment.
Bumping it to 14, on my macbook it take 1.320s.
diracdeltas
suggested changes
Aug 15, 2018
Slava
force-pushed
the
eth-wallet-password
branch
from
e16edc8 to
919d900
Compare
diracdeltas
approved these changes
Aug 15, 2018
Slava
added a commit
that referenced
this pull request
Aug 15, 2018
eth-wallet: password flow based on the hash stored on the fs
Slava
added a commit
that referenced
this pull request
Aug 15, 2018
eth-wallet: password flow based on the hash stored on the fs
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioning of the eth-wallet app is difficult so this update includes: