Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removing --cache.database arg #15032

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Removing --cache.database arg #15032

merged 1 commit into from
Aug 15, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 15, 2018

Fixes: #15023

It seems that this argument (which isn't really necessary on other machines) is causing memory issues on Linux (I confirmed this on Ubuntu). The memory allowance passed in for the DB i/o does not seem respected

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

(Using a Linux distro)

  1. Build Brave from this PR
  2. Start Brave, enable Eth Wallet
  3. By keeping geth running for a bit, confirm geth starts and functions normally, and does not run out of memory

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed fixes geth start on linux for me

@ryanml ryanml merged commit 79403cb into brave:master Aug 15, 2018
ryanml added a commit that referenced this pull request Aug 15, 2018
Removing --cache.database arg
ryanml added a commit that referenced this pull request Aug 15, 2018
Removing --cache.database arg
@ryanml
Copy link
Contributor Author

ryanml commented Aug 15, 2018

Master: 79403cb
0.24.x: ee4df6f
0.23.x: 82d7777

@ryanml ryanml deleted the fix-15023 branch August 15, 2018 23:19
@bsclifton bsclifton mentioned this pull request Aug 16, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants