Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes ENOENT issues on Windows #15033

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fixes ENOENT issues on Windows #15033

merged 1 commit into from
Aug 16, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 15, 2018

Fixes: #15031

geth.pid does not need to be a named pipe

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Slava
Slava previously approved these changes Aug 15, 2018
Copy link
Contributor

@Slava Slava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could simplify or put an explanatory comment if you want

@@ -185,9 +185,12 @@ const cleanupGethAndExit = (exitCode) => {
}

const cleanupGeth = (processId) => {
processId = processId || gethProcessId
processId = (
(processId || gethProcessId) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the extra pair of parens meaningful? Seems like it wouldn't change anything to remove them and the line would be read the same:

get processId or if it doesn't exist gethProcessId or if geth was running get geth pid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, sometimes I go a little extreme on the parens :) I can clean it up

@ryanml ryanml merged commit b9b616c into brave:master Aug 16, 2018
@ryanml ryanml deleted the fix-15031 branch August 16, 2018 00:11
ryanml added a commit that referenced this pull request Aug 16, 2018
Fixes ENOENT issues on Windows
ryanml added a commit that referenced this pull request Aug 16, 2018
Fixes ENOENT issues on Windows
@ryanml
Copy link
Contributor Author

ryanml commented Aug 16, 2018

master: b9b616c
0.24.x: 16a7383
0.23.x: d6475bf

@bsclifton bsclifton mentioned this pull request Aug 16, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants