Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move static-nodes.json write location #15034

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Move static-nodes.json write location #15034

merged 1 commit into from
Aug 15, 2018

Conversation

bkero
Copy link
Contributor

@bkero bkero commented Aug 15, 2018

This commit moves the static-nodes.json file from being written to
$DATADIR/geth/static-nodes.json to $DATADIR/static-nodes.json.

Testing from bkero and kjowiak confirmed that the file is actually read
from $DATADIR/

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

This commit moves the static-nodes.json file from being written to
$DATADIR/geth/static-nodes.json to $DATADIR/static-nodes.json.

Testing from bkero and kjowiak confirmed that the file is actually read
from $DATADIR/
@Slava
Copy link
Contributor

Slava commented Aug 15, 2018

lgtm

@bkero bkero requested review from mrose17, Slava, kjozwiak and evq August 15, 2018 21:12
@bkero bkero merged commit 5cc25fd into master Aug 15, 2018
@bkero bkero deleted the static-nodes-dir branch August 15, 2018 21:40
ryanml pushed a commit that referenced this pull request Aug 15, 2018
Move static-nodes.json write location
ryanml pushed a commit that referenced this pull request Aug 15, 2018
Move static-nodes.json write location
@ryanml
Copy link
Contributor

ryanml commented Aug 15, 2018

master: 5cc25fd
0.24.x: cd37100
0.23.x: 01096cb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants