Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert ETH Wallet functionality #15046

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Revert ETH Wallet functionality #15046

merged 1 commit into from
Aug 16, 2018

Conversation

bsclifton
Copy link
Member

Revert "Merge pull request #15035 from Slava/eth-wallet-payments"
This reverts commit 22f4cc8.

Revert "Merge pull request #15033 from ryanml/fix-15031"
This reverts commit 16a7383.

Revert "Merge pull request #15032 from ryanml/fix-15023"
This reverts commit ee4df6f.

Revert "Merge pull request #15034 from brave/static-nodes-dir"
This reverts commit cd37100.

Revert "Merge pull request #15029 from brave/geth-sanity-updates"
This reverts commit 84b416b.

Revert "Merge pull request #15022 from brave/deleteDidDetach"
This reverts commit c209fbd.

Revert "Merge pull request #15027 from Slava/eth-wallet-password"
This reverts commit c1d1fe9.

Revert "Merge pull request #14734 from Slava/feature/ethwallet"
This reverts commit 72820e8.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

This reverts commit 22f4cc8.

Revert "Merge pull request #15033 from ryanml/fix-15031"
This reverts commit 16a7383.

Revert "Merge pull request #15032 from ryanml/fix-15023"
This reverts commit ee4df6f.

Revert "Merge pull request #15034 from brave/static-nodes-dir"
This reverts commit cd37100.

Revert "Merge pull request #15029 from brave/geth-sanity-updates"
This reverts commit 84b416b.

Revert "Merge pull request #15022 from brave/deleteDidDetach"
This reverts commit c209fbd.

Revert "Merge pull request #15027 from Slava/eth-wallet-password"
This reverts commit c1d1fe9.

Revert "Merge pull request #14734 from Slava/feature/ethwallet"
This reverts commit 72820e8.
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanml ryanml merged commit cb1c815 into brave:master Aug 16, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this pull request Aug 16, 2018
ryanml added a commit that referenced this pull request Aug 16, 2018
ryanml added a commit that referenced this pull request Aug 16, 2018
@ryanml
Copy link
Contributor

ryanml commented Aug 16, 2018

master: cb1c815
0.24.x: 007d626
0.23.x: a340886

@bsclifton bsclifton deleted the revert-eth-wallet branch September 6, 2018 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants