From bf0cc2b2b227e960d6d18763dee2e0628a769a2b Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 28 Jul 2016 15:47:52 -0700 Subject: [PATCH] Return early when render widget host view is null --- atom/browser/api/atom_api_web_contents_mac.mm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/atom_api_web_contents_mac.mm b/atom/browser/api/atom_api_web_contents_mac.mm index 19246e82ac..913951737f 100644 --- a/atom/browser/api/atom_api_web_contents_mac.mm +++ b/atom/browser/api/atom_api_web_contents_mac.mm @@ -13,6 +13,9 @@ - (BOOL)isKeyWindow; namespace api { bool WebContents::IsFocused() const { + auto view = web_contents()->GetRenderWidgetHostView(); + if (!view) return false; + if (GetType() != BACKGROUND_PAGE) { auto window = web_contents()->GetTopLevelNativeWindow(); // On Mac the render widget host view does not lose focus when the window @@ -21,8 +24,7 @@ - (BOOL)isKeyWindow; return false; } - auto view = web_contents()->GetRenderWidgetHostView(); - return view && view->HasFocus(); + return view->HasFocus(); } } // namespace api