Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for interactions between Griffin-enabled features and existing features #543

Closed
fmarier opened this issue Sep 22, 2023 · 1 comment

Comments

@fmarier
Copy link
Member

fmarier commented Sep 22, 2023

Many of our features land behind a flag that is disabled by default. This enables gradual rollout of features via Griffin. Those features will typically contain a browser test which enables the flag before testing the feature. Therefore the feature itself passes its own tests prior to merge and rollout.

There is however a gap in our testing: browser tests for other features are never run with that new flag enabled. Instead, they run with the default value of the flag ("off") and so the interaction between the new to-be-rolled-out-later feature and existing features is not tested prior to rollout via Griffin.

One way to close that gap would be to require a PR which turns the flag on by default and runs through all browser tests successfully in CI, prior to enabling the feature for any users via Griffin.

Additionally, some of our features require supporting files to be shipped via the component updater before doing anything. We should ensure that all components are up to date before running these browser tests.

I suspect that these gaps in our testing explain why the regression described in brave/brave-browser#32462 was not caught quickly despite the fact that we do have a browser test for the query string filter.

@fmarier
Copy link
Member Author

fmarier commented Nov 9, 2023

@fmarier fmarier closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant