Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hang on macos #8

Merged
merged 5 commits into from
May 5, 2024
Merged

fix hang on macos #8

merged 5 commits into from
May 5, 2024

Conversation

bretello
Copy link
Owner

@bretello bretello commented Apr 29, 2024

  • gha: enable tests on MacOS
  • skip hanging tests on MacOS (python < 3.10.9)
  • add timeout to all workflows (pytest-timeout)
  • fix broken test_setupterm on MacOS

@bretello bretello force-pushed the fix-hang-on-macos branch 2 times, most recently from 6b09af7 to fdaa33a Compare May 3, 2024 09:21
@bretello bretello force-pushed the fix-hang-on-macos branch 2 times, most recently from 3a27f68 to 505bdc5 Compare May 3, 2024 17:59
On MacOS, `termiois.tcdrain` and `termios.tcsetattr(tty_fd, termios.TCSADRAIN, attrs)` hang up until 3.9.8.

See python/cpython#97001
@bretello bretello force-pushed the fix-hang-on-macos branch from 505bdc5 to 04d429c Compare May 3, 2024 18:02
@bretello bretello marked this pull request as ready for review May 5, 2024 09:35
@bretello
Copy link
Owner Author

bretello commented May 5, 2024

Test failures are related to codecov failing to upload the coverage report, see #9

@bretello bretello merged commit 9330c33 into master May 5, 2024
5 of 15 checks passed
@bretello bretello deleted the fix-hang-on-macos branch May 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant