Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu styles #119

Closed
tiborp opened this issue May 16, 2019 · 5 comments
Closed

Menu styles #119

tiborp opened this issue May 16, 2019 · 5 comments

Comments

@tiborp
Copy link
Contributor

tiborp commented May 16, 2019

Hi Brett,

I noticed when using some custom menu's (for example in the footer), I had to overwrite quite a bit of the menu styles; I think it would be a good idea to specify (parts of) the styling a bit more, as in targeting the --primary menu only. For example: visibility, hover states, z-index and the like.

Cheers, Tibor

@brettsmason
Copy link
Owner

Yep agreed, I just haven't got round to it yet 😄
I've been having to do that on most new projects, but haven't had time to put something together for the repo yet.

@tiborp
Copy link
Contributor Author

tiborp commented May 16, 2019

👍

@brettsmason
Copy link
Owner

@tiborp I finally got round to rewriting the menu styles.
It now works by adding menu--responsive to the <nav> element. This keeps the default .menu class clean now.

Feel free to give it a try and let me know how you get on 😄

@tiborp
Copy link
Contributor Author

tiborp commented Jul 29, 2019

Hi Brett,
Sorry for the late notice! Still haven't found the time for further testing this, but I'm pretty sure this will do the trick.

@brettsmason
Copy link
Owner

@tiborp That's ok was just having a clean up 😄
I'm in the process of trying out Tailwind with the project so this may change again anyway in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants