Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive menu implementation in other theme #285

Closed
tiborp opened this issue Apr 12, 2021 · 2 comments
Closed

Responsive menu implementation in other theme #285

tiborp opened this issue Apr 12, 2021 · 2 comments

Comments

@tiborp
Copy link
Contributor

tiborp commented Apr 12, 2021

Hi Brett!

I am currently working on an _s based starter theme and trying to implement your responsive-menu.js.

I have managed to add the proper BEM classes to the navigation, but somehow get the following error:

Uncaught ReferenceError: menuIcons is not defined
    at new ResponsiveMenu (responsive-menu.js:13)

Hope you can help me on my way solving this.

Cheers, Tibor

@brettsmason
Copy link
Owner

Hey Tibor!

So in V1 of the theme there was this:

wp_localize_script(

That was just a way to pass the svg to the menu, but you could just update the script to have that in line instead, or remove it.

Hope that helps!

@tiborp
Copy link
Contributor Author

tiborp commented Apr 12, 2021

Aaah...of course! I totally missed that one :-S
Thanks so much!!

@tiborp tiborp closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants