Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racon 1.4.13 #1105

Merged
merged 4 commits into from
Jul 27, 2020
Merged

racon 1.4.13 #1105

merged 4 commits into from
Jul 27, 2020

Conversation

SeekingMeaning
Copy link
Contributor

Created with brew bump-formula-pr.

@sjackman
Copy link
Member

On macOS

/tmp/racon-20200718-16773-12tzjs3/racon-v1.4.13/vendor/spoa/src/alignment_engine.cpp:37:20: error: 'invalid_argument' is not a member of 'std'
   37 |         throw std::invalid_argument("[spoa::createAlignmentEngine] error: "
      |                    ^~~~~~~~~~~~~~~~

https://github.com/brewsci/homebrew-bio/pull/1105/checks?check_run_id=884266939#step:4:180

@sjackman
Copy link
Member

On Linux

==> brew test --verbose brewsci/bio/unicycler
104
==> FAILED
105
Testing brewsci/bio/unicycler
106
==> /home/linuxbrew/.linuxbrew/Cellar/unicycler/0.4.7/bin/unicycler --help
107
Error: brewsci/bio/unicycler: failed
108
An exception occurred within a child process:
109
  Errno::ENOENT: No such file or directory - /home/linuxbrew/.linuxbrew/Cellar/unicycler/0.4.7/bin/unicycler
110

https://github.com/brewsci/homebrew-bio/pull/1105/checks?check_run_id=884266950#step:5:109

Looks like maybe Unicycler needs to be revision bumped, possibly due to python. That could be done in a separate PR.

@SeekingMeaning
Copy link
Contributor Author

Vendored spoa is version 3.0.2, and the invalid_argument error is fixed in 3.1.1
rvaser/spoa@06d58ef


def install
rm_rf "vendor/spoa"
(buildpath/"vendor/spoa").install resource("spoa")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@SeekingMeaning SeekingMeaning merged commit 5608335 into brewsci:develop Jul 27, 2020
@SeekingMeaning SeekingMeaning deleted the racon-1.4.13 branch July 27, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants