You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add tests for keys that aren't multiples of 1024 bits.
Add support (and tests) for keys larger than 4096 bits.
At least for PSS, and maybe PKCS#1 1.5, it seems we can reduce allocations in the application of the padding; we should do that. Here's the key point from Implement RSA PSS verification and signing. #262: "Instead of setting out to "PS || 0x01 || salt" and then masking it with db_mask, why not fill out with the MGF1 output and then mask "PS || 0x01 || salt" onto it? Wouldn't this avoid the need for the extra buffer?": Done.
The text was updated successfully, but these errors were encountered:
I factored out some of the bullet points in the initial comment into their own issues. Besides the things noted above, there are many issues tagged "rsa", most of which are about RSA signing.
Roughly in order of priority:
BN_mod_exp_consttime
, caused by strict aliasing violations.BN_mod_exp_consttime
. Done in 52879da.BN_reduce_montgomery
should be reviewed and tested. I believe it can be simplified to a single multiplication.GFp_rsa_private_transform
should be redone in Rust: Implement RSA signing (using CRT) in Rust, replacingGFp_rsa_private_transform
#365.The text was updated successfully, but these errors were encountered: