Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DER-handling code from the main crate #586

Closed
P-E-Meunier opened this issue Oct 25, 2017 · 2 comments
Closed

Separate DER-handling code from the main crate #586

P-E-Meunier opened this issue Oct 25, 2017 · 2 comments

Comments

@P-E-Meunier
Copy link
Contributor

I'd like to handle as many key formats as possible. PR #582 is a format-independent interface to load keys, and this could allow *ring* to get rid of all its ASN.1 handling, which is not its main added value.

I've started to work on such an interface in thrussh-keys, and this works fine for RSA and Ed25519 keys, encrypted or not, in several formats, including PKCS#8, but also legacy formats used by OpenSSH.

The parsing in thrussh-keys is done using "yasna", a crate to parse DER. That crate is a little wasteful in terms of memory at the moment, but it's also fairly young (0.1). The interface doesn't look too different from what *ring* does.

@newpavlov
Copy link
Contributor

@briansmith
What do you think about it? I could prepare PRs for ring and webpki if you interested in it.

@briansmith
Copy link
Owner

Probably not going to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants