Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify ReBuffer length #157

Closed
bkhall opened this issue Mar 30, 2016 · 3 comments
Closed

Add ability to specify ReBuffer length #157

bkhall opened this issue Mar 30, 2016 · 3 comments
Milestone

Comments

@bkhall
Copy link

bkhall commented Mar 30, 2016

  • [ x ] I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • ExoMedia version: 2.5.5
  • Device OS version: 6.0
  • Devide Manufacturer: Samsung
  • Device Name: Galaxy S6
Reproduction Steps

Start a remote stream, especially on a slow or low bandwidth (cell) connection.

Expected Result

Starts playing

Actual Result

Buffers indefinitely, may eventually play.

Reference:
google/ExoPlayer#1285

It seems your library either needs to set minRebufferMs to 0 or expose it so we can manipulate it to work around the ExoPlayer issue.

@brianwernick brianwernick changed the title Player stuck in buffering state Add ability to specify ReBuffer length Mar 30, 2016
@brianwernick
Copy link
Owner

Currently it is expected that the media won't play until you get some amount of media to play. In your case where it will sometimes play to me this means that you just need to wait (and it isn't actually in Buffering indefinitely). As such, the ability to override player = ExoPlayer.Factory.newInstance(RENDER_COUNT, BUFFER_LENGTH_MIN, REBUFFER_LENGTH_MIN); or specify the REBUFFER_LENGTH_MIN will be a future feature

@brianwernick brianwernick added this to the 3.x milestone Mar 30, 2016
@bkhall
Copy link
Author

bkhall commented Mar 30, 2016

Of course...

However it's impossible to know the difference between, just wait, and never starts. The instances where we just waiting works, is on the order of minutes, sometimes tens of minutes, Most users just bail and fail into the never starts complaint.

So, I'll have to fork and mod it myself until it gets fixed, by either you or ExoPlayer.

But at least you know about it now.

@brianwernick
Copy link
Owner

You are always welcome to make the change and create a PR against the 3.0 branch as well.

@brianwernick brianwernick mentioned this issue Apr 4, 2017
1 task
@brianwernick brianwernick modified the milestones: 4.0.0, 4.x Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants