Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SelectVariants to handle the * allele properly #4258

Closed
ldgauthier opened this issue Jan 25, 2018 · 1 comment
Closed

Enable SelectVariants to handle the * allele properly #4258

ldgauthier opened this issue Jan 25, 2018 · 1 comment
Assignees

Comments

@ldgauthier
Copy link
Contributor

I'm sick and tired of dancing around the stupid * allele after I subset a big callset to my truth sample.

If I run SelectVariants with --sample-name sample1 --exclude-non-variants and sample1 is heterozygous ref/* or homozygous for the * then I would like the line in the VCF to get dropped.
My rationale is that the output of that command for less complicated variants is the same as the output if the sample had been run by itself (aside from extra ALTs in the SelectVariants case without --remove-unused-alternates).

I'm willing to concede a --keep-star-only-variants argument to override this behavior.

Any arguments against? Any other nagging * issues for SelectVariants?

@ldgauthier
Copy link
Contributor Author

Closed via #5129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant