Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funcotator - VCFOutputRenderer needs to be reviewed with new changes from MAF #4583

Closed
jonn-smith opened this issue Mar 26, 2018 · 2 comments
Assignees
Milestone

Comments

@jonn-smith
Copy link
Collaborator

jonn-smith commented Mar 26, 2018

The MafOutputRenderer changed how some funcotation fields are accessed.

Need to make VCF output consistent with the code in MAF output, and need to make sure it's consistent to the VCF format.

Specifically, VCFOutputRenderer should use the funcotation map that is now created internally to go through and render the annotations.

Specifically use Funcotation::getFieldNames and Funcotation::getField.

@LeeTL1220
Copy link
Contributor

I think this is already done as part of #4872 ... @jonn-smith Can you confirm?

@jonn-smith
Copy link
Collaborator Author

@LeeTL1220 actually I think this was actually addressed in #4838.

Either way, I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants