Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatherTranches fails due to what seems like an integer overflow #7859

Open
LindoNkambule opened this issue May 18, 2022 · 2 comments
Open

GatherTranches fails due to what seems like an integer overflow #7859

LindoNkambule opened this issue May 18, 2022 · 2 comments

Comments

@LindoNkambule
Copy link

Bug Report

Affected tool(s) or class(es)

GatherTranches

Affected version(s)

Latest public release version 4.2.6.1

Description

I ran VariantRecalibrator in scattered (using intervals) mode and now trying to gather the scattered tranches into a single file but somehow the number of novel variants is < 0. This is the exact error:
Invalid tranche - no. variants is < 0 : known 90357410 novel -1894637320

Steps to reproduce

inputs_cmdl = ' '.join([f'--input {t}' for t in tranches])
j.command(
        f"""set -euo pipefail
        gatk --java-options -Xms6g \\
          GatherTranches \\
          --mode SNP \\
          {inputs_cmdl} \\
          --output {j.out_tranches}"""
)

Expected behavior

Gathered scattered VQSLOD tranches into a single file

Actual behavior

Fails because of what seems like an integer overflow according to @ldgauthier

org.broadinstitute.hellbender.exceptions.GATKException: Invalid tranche - no. variants is < 0 : known 90357410 novel -1894637320
	at org.broadinstitute.hellbender.tools.walkers.vqsr.Tranche.<init>(Tranche.java:37)
	at org.broadinstitute.hellbender.tools.walkers.vqsr.VQSLODTranche.<init>(VQSLODTranche.java:37)
	at org.broadinstitute.hellbender.tools.walkers.vqsr.VQSLODTranche.mergeAndConvertTranches(VQSLODTranche.java:205)
	at org.broadinstitute.hellbender.tools.walkers.vqsr.VQSLODTranche.mergeAndConvertTranches(VQSLODTranche.java:139)
	at org.broadinstitute.hellbender.tools.walkers.vqsr.GatherTranches.doWork(GatherTranches.java:80)
	at org.broadinstitute.hellbender.cmdline.CommandLineProgram.runTool(CommandLineProgram.java:140)
	at org.broadinstitute.hellbender.cmdline.CommandLineProgram.instanceMainPostParseArgs(CommandLineProgram.java:192)
	at org.broadinstitute.hellbender.cmdline.CommandLineProgram.instanceMain(CommandLineProgram.java:211)
	at org.broadinstitute.hellbender.Main.runCommandLineProgram(Main.java:160)
	at org.broadinstitute.hellbender.Main.mainEntry(Main.java:203)
	at org.broadinstitute.hellbender.Main.main(Main.java:289)

Description

Use a data type like long that can store larger values instead of int ?

@droazen
Copy link
Contributor

droazen commented May 23, 2022

@LindoNkambule For your dataset, do you expect an extremely large number of novel variants (on the order of 2 billion+)? How many total variants are in your dataset?

@ldgauthier Have you ever encountered an error like this?

@droazen
Copy link
Contributor

droazen commented May 23, 2022

(Never mind -- I see that there is already a proposed PR to fix this!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants