Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thank you for the fantastic mod!
I'm not proficient in C++, and I'm an absolute noob in quest mod development, but here's my attempt to enhance the search functionality. Currently, it performs poorly and most of the time it is nearly impossible to find songs by artists or by song name, in my opinion. Also, from time to time, there are some random results at the top.
I checked the algorithm and was a bit surprised with a woogabooga logic. The scoring was calculated based on some questionable conditions. Additionally, I believe sorting shouldn't impact the scoring at all; it should only reorder entries that were filtered previously (by ignoring any scores retrieved before).
Better song search for the
BetterSongSearchQuest
!So, here are the changes I made:
AND
operation over multiple prefix searchesRelevance
sorting option (default) that currently uses scores (weights), but later on, it could be improved by including extra weights based on other properties (for example, rating might slightly affect the score).I understand that this is a port of the desktop mod version, and I'm not sure if it's okay to change the logic to be completely different from how it was implemented there.
Anyway, please try the new logic locally and let me know if it really works better than before or not (at least now I can find songs 😄)
fixes #17
offtop:
I'm facing an issue with the
./copy.ps1
script on windows (quest3):Maybe you know how to resolve the issue with the failed copy operation? The mod is disabled after this. Instead of this, I am currently building the qmod file and patching via QuestPatcher.