Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata tag and acknowledgement to PTCs #43

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jun 21, 2022

As part of the PSIP automation process, we want to add some metadata that can be traced (via github searches) when a project uses one of the catalog cards.

This PR recommends adding both metadata to the top (which will not render on GitHub or GitLab but will be in the raw source code) and an acknowledgement at the bottom. In this way, if a project is copy-pasting an existing PTC into their own repo, it should be searchable in two ways.

NOTE: The choice ecp-psip-ptc is for uniqueness. In searching all of GitHub, I didn't find a use of that tag or phrase anywhere that is unrelated to ECP.

EDIT: Partially resolves #41

@rmmilewi
Copy link
Member

Sounds good to me! 😄

@elaineraybourn
Copy link
Member

@mrmundt thanks for your progress on this. One thing to consider -- We are moving along the path of PSIP automation so the toolkit outlives the ECP project. So...as you have "ecp" in the metadata tag -- how would you like to address this? Thanks!

@mrmundt
Copy link
Contributor Author

mrmundt commented Jun 22, 2022

@elaineraybourn - That's a good question. I originally had the tag as psip-ptc, but that is not unique across all of GitHub. That is, there are other repositories and projects that use that acronym (not a lot, but they are there!). Is there an inherent problem in saying, "This was originally created through efforts by ECP"? If there isn't, I don't see an outright problem with ecp-psip-ptc.

That being said, another option I like is bssw-psip-ptc because a lot of the info is hosted in the bssw-psip organization and GitHub Page. Thoughts?

@elaineraybourn
Copy link
Member

elaineraybourn commented Jun 22, 2022

@mrmundt I like bssw-psip-ptc better. Bssw won't change soon.

@mrmundt
Copy link
Contributor Author

mrmundt commented Jun 22, 2022

@elaineraybourn - Changed!

Any thoughts on the acknowledgement language?

@elaineraybourn
Copy link
Member

@mrmundt can you make a few suggestions to choose from? What would Uncle Bob do? WWUBD. :-)

@mrmundt
Copy link
Contributor Author

mrmundt commented Jun 22, 2022

@elaineraybourn - Sorry, I forget that you're not primarily a software developer! If you click on "Files changed", you can see that I added some language already based on what I thought was good. The language I added to each file was:

Acknowledgement

This Project Tracking Card originated from the PSIP PTC Catalog. The development of the PSIP PTC Catalog was supported by the Exascale Computing Project (17-SC-20-SC), a collaborative effort of the U.S. Department of Energy Office of Science and the National Nuclear Security Administration.

@mrmundt mrmundt merged commit dcb975d into bssw-psip:master Jun 23, 2022
@mrmundt mrmundt deleted the add-metadata-tag branch June 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label PTCs?
3 participants