Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkedin icon is almost invisible on dark background #70

Closed
martin-weber opened this issue Nov 6, 2017 · 6 comments
Closed

linkedin icon is almost invisible on dark background #70

martin-weber opened this issue Nov 6, 2017 · 6 comments
Assignees

Comments

@martin-weber
Copy link

martin-weber commented Nov 6, 2017

Is it possible to invert the linkedin icon, so that it is visible like the other icons on dark backgrounds?

@budparr
Copy link
Member

budparr commented Nov 6, 2017

Hey, @martin-weber Can you put up a screenshot, or point me to a website? I think I have a good solution for this.

@budparr budparr self-assigned this Nov 6, 2017
@martin-weber
Copy link
Author

The background is an image of a skyline at night.

This is the screenshot without hover:
bildschirmfoto 2017-11-06 um 23 11 31

This is the screenshot with mouse hover.
bildschirmfoto 2017-11-06 um 23 11 57

@martin-weber
Copy link
Author

What I've seen as well is that the _social-icons.css file does not contain linkedin-class in the first line.

.facebook, .twitter, .instagram, .youtube, .github { fill: #BABABA; }

@budparr
Copy link
Member

budparr commented Nov 6, 2017

Yeah, sorry about that. The linkedin came through in a PR and I guess I wasn't thorough in my review. I'm going to see if I can fix it up right now.

@martin-weber
Copy link
Author

martin-weber commented Nov 6, 2017

Thank you.
I like this template. Great work!

@budparr budparr closed this as completed in ff25b71 Nov 6, 2017
@budparr
Copy link
Member

budparr commented Nov 6, 2017

Should be fixed now. Thanks for bringing it to my attention, @martin-weber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants