fix(code-generation): Imports with no specifiers are generated correc…

…tly (#264)
buehler · Aug 10, 2017 · abaa2dd · abaa2dd
1 parent 0ea7816
commit abaa2dd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/extension/extension.ts b/src/extension/extension.ts
@@ -26,7 +26,7 @@ function extendGenerator(generator: TypescriptCodeGenerator): void {
     GENERATORS[RegexImportGroup.name] = simpleGenerator;
     GENERATORS[RemainImportGroup.name] = simpleGenerator;
     GENERATORS[ImportProxy.name] = (proxy: ImportProxy) => {
-        if (proxy.specifiers.length <= 0) {
+        if (proxy.specifiers.length <= 0 && (proxy.defaultAlias || proxy.defaultPurposal)) {
             return generator.generate(
                 new DefaultImport(
                     proxy.libraryName, (proxy.defaultAlias || proxy.defaultPurposal)!, proxy.start, proxy.end,

diff --git a/test/extension/proxy-objects/ImportProxy.test.ts b/test/extension/proxy-objects/ImportProxy.test.ts
@@ -184,7 +184,7 @@ describe('ImportProxy', () => {
 
         before(() => {
             GENERATORS[ImportProxy.name] = (proxy: ImportProxy) => {
-                if (proxy.specifiers.length <= 0) {
+                if (proxy.specifiers.length <= 0 && (proxy.defaultAlias || proxy.defaultPurposal)) {
                     return generator.generate(
                         new DefaultImport(
                             proxy.libraryName, (proxy.defaultAlias || proxy.defaultPurposal)!, proxy.start, proxy.end,
@@ -238,6 +238,10 @@ describe('ImportProxy', () => {
             generator.generate(proxy).should.equal(`import ALIAS from 'foo'`);
         });
 
+        it('should generate an empty named import if no specifiers and no default is set', () => {
+            generator.generate(proxy).should.equal(`import { } from 'foo';`);
+        });
+
     });
 
 });