Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restify: consider providing original request in beforeSend #475

Open
karthikiyengar opened this issue Feb 4, 2019 · 2 comments
Open

restify: consider providing original request in beforeSend #475

karthikiyengar opened this issue Feb 4, 2019 · 2 comments
Labels
needs discussion Requires internal analysis/discussion

Comments

@karthikiyengar
Copy link

This is also in close connection with #420

For instance, I would like to use the original request to tag along req.user which contains my user details - something that the restify plugin does not do automatically.

The current approach makes the plugin pretty inflexible and the only way I can modify getRequestAndMetaDataFromReq is to fork.

@karthikiyengar
Copy link
Author

My current solution is to add another middleware after the bugsnag requestHandler to attach the user to the req.bugsnag.

@bengourley
Copy link
Contributor

Thanks for the feedback. Your solution sounds reasonable but we'll look at this and see if there's a nicer api we can provide.

@bengourley bengourley added the needs discussion Requires internal analysis/discussion label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Requires internal analysis/discussion
Projects
None yet
Development

No branches or pull requests

2 participants