Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Trusted Builders #167

Closed
2 tasks done
dfreilich opened this issue Jul 2, 2020 · 8 comments · Fixed by #191
Closed
2 tasks done

Document Trusted Builders #167

dfreilich opened this issue Jul 2, 2020 · 8 comments · Fixed by #191
Assignees
Labels
status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@dfreilich
Copy link
Member

dfreilich commented Jul 2, 2020

Summary

We now have a concept of a trusted builder, and we should document it.

What questions should this documentation answer?

  • What is a trusted builder? What is an untrusted builder?
  • What practical difference is there between them?
  • What commands can I use with trusted or untrusted builders?

Who is the target audience for this documentation?

  • App Developer
  • Operator

Additional Information

Relevant RFCs:

@dfreilich dfreilich added the type/enhancement Issue that requests a new feature or improvement. label Jul 2, 2020
@yaelharel
Copy link
Contributor

yaelharel commented Jul 2, 2020

I would add to "What questions should this documentation answer?":

  • How can I trust/untrust builders?
  • How can I see what builders are trusted?

@jromero
Copy link
Member

jromero commented Jul 2, 2020

One thing to keep in mind is that this feature is specific to pack and NOT the buildpacks project as a whole. I would suggest that we have a section of the site dedicated to pack.

@dfreilich
Copy link
Member Author

Hmm. But it did go through the RFC/spec process, and it is formally added to the spec, so it's a bit more broad than only pack, though in implementation it is only used by pack.

@dfreilich
Copy link
Member Author

With #161, we should have a section for pack!

@jromero
Copy link
Member

jromero commented Jul 2, 2020

Hmm. But it did go through the RFC/spec process, and it is formally added to the spec, so it's a bit more broad than only pack, though in implementation it is only used by pack.

I see the RFC (buildpacks/rfcs#46) that you might be referencing but it's more about creator with some example cases on how pack would use it. I can't see how the implementation in how/why we use creator vs phases in pack is something that is CNB project wide. Could you elaborate a little more and maybe provide some reference?

@dfreilich
Copy link
Member Author

Ah never mind, with the spec, I was thinking about the project descriptor (#165 ).

@dfreilich
Copy link
Member Author

But I do think it is important, particularly given the presence of trusted builders in our commands and logs, to have some good and clear documentation around it

@dfreilich
Copy link
Member Author

The split between pack/buildpacks/lifecycle in the docs is an interesting/difficult one, because in practice most of the docs site is for pack (for instance, all of the guides are leading through pack commands).

@jromero jromero added this to the pack/0.13.0 milestone Aug 18, 2020
@simonjjones simonjjones self-assigned this Aug 18, 2020
@simonjjones simonjjones added the status/in-progress Issue or PR that is currently in progress. label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants