Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-builder should be able to create a Windows image #469

Closed
natalieparellano opened this issue Jan 24, 2020 · 1 comment · Fixed by #571
Closed

create-builder should be able to create a Windows image #469

natalieparellano opened this issue Jan 24, 2020 · 1 comment · Fixed by #571
Assignees
Labels
os/windows status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Jan 24, 2020

Description

pack create-builder currently only creates Linux images.

Proposed solution

pack (compiled for Linux and Mac) and pack.exe (compiled for Windows) should be able to create Windows images.

Describe alternatives you've considered

Additional context

  • Leaving buildpackages out of scope for now due to their complexity
  • Leaving validation of lifecycle/stack-image OS matching for a future issue (including download of default lifecycle).
  • Currently, layer tar files are written with paths starting from e.g., /cnb - this should be Files/cnb on Windows
  • It might be best for Lifecycle should compile and package on Windows lifecycle#234 to be completed before this issue can be tackled

Possible acceptance criteria

  • Given a builder.toml that references a Windows stack and lifecycle
  • pack create-builder windows-builder --builder-config <path to builder.toml> should succeed when run with and without --publish
  • pack.exe create-builder windows-builder --builder-config <path to builder.toml> should succeed when run with and without --publish
  • pack inspect-builder windows-builder should succeed
  • docker run windows-builder should succeed and we should see that the lifecycle executables are present in the image at the expected location
@natalieparellano
Copy link
Member Author

Reminder: confirm imgutil and pack both have secure containerized registries

@natalieparellano natalieparellano removed their assignment Mar 10, 2020
@ameyer-pivotal ameyer-pivotal self-assigned this Apr 10, 2020
@natalieparellano natalieparellano added status/in-progress Issue or PR that is currently in progress. and removed status/ready Issue ready to be worked on. labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os/windows status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants