Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR change to DefaultLifecycleVersion when lifecycle is released #714

Closed
natalieparellano opened this issue Jun 25, 2020 · 0 comments · Fixed by #724
Closed

PR change to DefaultLifecycleVersion when lifecycle is released #714

natalieparellano opened this issue Jun 25, 2020 · 0 comments · Fixed by #724
Labels
status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@natalieparellano
Copy link
Member

Description

Today, the default lifecycle version is specified here:

pack/internal/builder/lifecycle.go

Line 18 in 972ed1e

DefaultLifecycleVersion = "0.7.5"
and here:

pack/acceptance/testdata/pack_fixtures/report_output.txt

Line 5 in 972ed1e

Default Lifecycle Version: 0.7.5

When new lifecycle releases are cut, we have to remember to change this code. We sometimes lag getting this updated because we forget.

Proposed solution

We should have a GitHub action to create a PR to update the version number when new releases are cut. We can merge the PR when it makes sense to do so.
@natalieparellano natalieparellano added type/chore Issue that requests non-user facing changes. status/triage Issue or PR that requires contributor attention. status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Jun 25, 2020
@jromero jromero mentioned this issue Jul 1, 2020
Merged
1 task
@jromero jromero closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update default lifecycle to 0.8.0 buildpacks/pack
2 participants
@jromero @natalieparellano