Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--env-file does not expose variables to detect #83

Closed
nebhale opened this issue Dec 13, 2018 · 2 comments
Closed

--env-file does not expose variables to detect #83

nebhale opened this issue Dec 13, 2018 · 2 comments
Assignees

Comments

@nebhale
Copy link
Contributor

nebhale commented Dec 13, 2018

In the latest revision of the spec, environment variables are exposed during detection. At the moment, these environment variable are only exposed during the build phase. They should be exposed during the detect phase as well.

@ameyer-pivotal ameyer-pivotal self-assigned this Dec 18, 2018
@sclevine
Copy link
Member

sclevine commented Jan 4, 2019

Looks good:

liberty:pack pivotal$ ./pack-676-osx build myapp --builder packs/samples:0.0.1-rc.490 --buildpack ./test-bp/ --env-file <(echo 'TESTME=pass')
Defaulting app directory to current working directory /Users/pivotal/workspace/cncf-buildpacks/pack (use --path to override)
Using user-provided builder image packs/samples:0.0.1-rc.490
Pulling builder image packs/samples:0.0.1-rc.490 (use --no-pull flag to skip this step)
Selected run image packs/run:v3alpha2 from stack io.buildpacks.stacks.bionic
Pulling run image packs/run:v3alpha2 (use --no-pull flag to skip this step)
Using cache volume pack-cache-7bae996a0e238a80f14b74a61e3178bf
===> DETECTING
Using manually-provided group
[detector] 2019/01/04 16:01:59 Trying group of 1...
[detector] 2019/01/04 16:01:59 ======== Output:  ========
[detector]
[detector] 2019/01/04 16:01:59 ======== Results ========
[detector] 2019/01/04 16:01:59 : pass

@ekcasey
Copy link
Member

ekcasey commented Jan 9, 2019

released in pack v0.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants