Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness #13

Open
puredevotion opened this issue Mar 19, 2015 · 8 comments
Open

Responsiveness #13

puredevotion opened this issue Mar 19, 2015 · 8 comments

Comments

@puredevotion
Copy link

I'm implementing the latest version, and although it works great, whenever I open the frontpage on a mobile device the plugin breaks responsiveness.

I'm bluntly assuming this is because the plugin uses tables for layout, instead of divs.

I'm willing to help refactor it to divs, but figured that before just pushing in a pull-request I'd check what your thoughts are.

@zigojacko
Copy link

One of the first things I did ages ago now was convert this from tables so that it works responsively. I thought I had submitted my changes on here but I guess not.

@puredevotion
Copy link
Author

@zigojacko do you happen to have that laying around? I'd be hapy to adjust it for the current version.

@laurenclark
Copy link

Would really like that conversion!

@zigojacko
Copy link

I should have it somewhere yes, I'm up to my neck in work currently but I'll try and dig it out asap. Feel free to keep bugging me for it... (else I will forget). Thanks.

@laurenclark
Copy link

@zigojacko Sorry man if you've got five minutes I'm really behind on my first ever Mage project - pleasepleaseplease?

@zigojacko
Copy link

Just forked and committed changes (I think it was just this file that was edited, I can't recall) - sorry not got time to check properly via git.

https://github.com/zigojacko/Inchoo_FeaturedProducts/blob/master/app/design/frontend/base/default/template/inchoo/featuredproducts/block_featured_products.phtml

@laurenclark
Copy link

Thanks so much

@kush1960
Copy link
Contributor

@zigojacko that didn't work for me, possibly missing CSS?
I fixed it myself by using the default RWD theme product grid markup if anyone want to try this...
#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@puredevotion @zigojacko @kush1960 @laurenclark and others