Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{{did-update}} fails for Ember 3.23 beta #282

Closed
simonihmig opened this issue Oct 23, 2020 · 3 comments · Fixed by #286
Closed

{{did-update}} fails for Ember 3.23 beta #282

simonihmig opened this issue Oct 23, 2020 · 3 comments · Fixed by #286

Comments

@simonihmig
Copy link

Does not call the callback, in Ember 3.23.0-beta and 3.24.0-canary.

Reproduction: ember try:one ember-beta

This is not visible in Travis yet, as CI is even failing earlier: #281 (see all those pending dependabot PRs)
@simonihmig simonihmig mentioned this issue Oct 23, 2020
Merged
@boris-petrov
Copy link
Contributor

I just hit this in 3.23.0 final. @buschtoens - any ideas?

@buschtoens
Copy link
Owner

Thanks for pinging! This seems to have slipped past my attention, sorry.

I'll try to look into it today.

@boris-petrov boris-petrov mentioned this issue Nov 17, 2020
Merged
@buschtoens
Copy link
Owner

Published as v0.2.0. 🚀

Thank you for your contributions! And sorry that I left you hanging for so long :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: did-update entaglement on Ember 3.23+
3 participants
@boris-petrov @buschtoens @simonihmig