-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport new helper names to v0.2 to avoid dependency hell #453
Comments
@buschtoens: Can I interpret your thumbs up as looking forward for a PR? |
@ijlee2 Are you open to release such a v0.2 release easing the upgrade path? I have some time working on it tomorrow. But would be great having a confirmation before that you are open to releasing it. |
Hi, @jelhan. I missed the notification from this issue, my bad. Yes, I agree that releasing Either way, I think it'd be good to call Ember's |
Thanks for your quick response. I will provide a PR as soon as possible. If all goes well by tomorrow. |
@ijlee2 I have implemented the changes here: https://github.com/buschtoens/ember-render-helpers/compare/v0.2.0...jelhan:ember-render-helpers:backport-new-helper-names-to-v0.2?expand=1 I branched of from I cannot create a PR because there isn't a target branch in this repository. Do you mind creating a new branch with name
|
@jelhan Thanks again for your help. I published |
Thanks a lot. Working as expected. |
Are you open to backport the helper renaming to v0.2 as well?
Having a v0.2.1 release with the new names in addition to the old once would help with upgrading as addons could support
^0.2.0 || ^1.0.0
. The current setup forces an addon upgrading to v1 dropping support for v0.2 at the same time. Applications using multiple addons which depend on ember-render-helper are forced to upgrade all of them at once. This often slows down upgrading any of them and causes additional work due to amount of changes needed at once.Every addon could work around using Embroider Macros. But I feel it is easier solving it once by having a v0.2.1 release of ember-render-helpers, which provides the new names as alias.
The text was updated successfully, but these errors were encountered: