Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport new helper names to v0.2 to avoid dependency hell #453

Closed
jelhan opened this issue Oct 24, 2024 · 7 comments
Closed

Backport new helper names to v0.2 to avoid dependency hell #453

jelhan opened this issue Oct 24, 2024 · 7 comments

Comments

@jelhan
Copy link

jelhan commented Oct 24, 2024

Are you open to backport the helper renaming to v0.2 as well?

Having a v0.2.1 release with the new names in addition to the old once would help with upgrading as addons could support ^0.2.0 || ^1.0.0. The current setup forces an addon upgrading to v1 dropping support for v0.2 at the same time. Applications using multiple addons which depend on ember-render-helper are forced to upgrade all of them at once. This often slows down upgrading any of them and causes additional work due to amount of changes needed at once.

Every addon could work around using Embroider Macros. But I feel it is easier solving it once by having a v0.2.1 release of ember-render-helpers, which provides the new names as alias.

@jelhan
Copy link
Author

jelhan commented Oct 25, 2024

@buschtoens: Can I interpret your thumbs up as looking forward for a PR?

@jelhan
Copy link
Author

jelhan commented Nov 4, 2024

@ijlee2 Are you open to release such a v0.2 release easing the upgrade path? I have some time working on it tomorrow. But would be great having a confirmation before that you are open to releasing it.

@ijlee2
Copy link
Collaborator

ijlee2 commented Nov 4, 2024

Hi, @jelhan. I missed the notification from this issue, my bad.

Yes, I agree that releasing 0.2.1 with the new names would help. To confirm, will you create such a pull request, or did you need me to? (I'd prefer the former due to a lack of time.)

Either way, I think it'd be good to call Ember's deprecate() method in the helpers without -helper. Can you check the format shown in ijlee2/ember-container-query@c758c51 (i.e. call deprecate() in the source files in addon, not in the re-export files in app)?

@jelhan
Copy link
Author

jelhan commented Nov 4, 2024

Thanks for your quick response. I will provide a PR as soon as possible. If all goes well by tomorrow.

@jelhan
Copy link
Author

jelhan commented Nov 8, 2024

@ijlee2 I have implemented the changes here: https://github.com/buschtoens/ember-render-helpers/compare/v0.2.0...jelhan:ember-render-helpers:backport-new-helper-names-to-v0.2?expand=1

I branched of from v0.2.0 tag (71f650b).

I cannot create a PR because there isn't a target branch in this repository. Do you mind creating a new branch with name v0.2.x or alike based on v0.2.0 (71f650b)? I can create the PR afterwards.

GitHub
Complimentary render template helpers to the render modifiers - Comparing buschtoens:v0.2.0...jelhan:backport-new-helper-names-to-v0.2 · buschtoens/ember-render-helpers

@ijlee2
Copy link
Collaborator

ijlee2 commented Nov 11, 2024

@jelhan Thanks again for your help. I published 0.2.1, which should help your migration case.

@ijlee2 ijlee2 closed this as completed Nov 11, 2024
@jelhan
Copy link
Author

jelhan commented Nov 11, 2024

Thanks a lot. Working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants