Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Update to use glimmer component #59

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

lukemelia
Copy link
Collaborator

@lukemelia lukemelia commented Jun 8, 2020

Drops support for Ember versions < 3.16

  • Refactor component to Glimmer
  • Drop ember-wormhole in favor of in-element helper (via ember-in-element-polyfill)
  • Drop support for looking up DOM document on old Ember versions
  • Update dependencies
  • Convert tests to use Glimmer components for cards and atoms
  • Drop dependencies on ember-fetch, rsvp and chai
  • Update to reflect dropped compatibility with < 3.16

Because compatibility with Ember 4 requires ember-auto-import 2, and addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, we will save this for a separate PR and release.

@donaldsonjulia
Copy link

I would love to see this get merged if there is clarification on backwards compatibility requirements. Without this update, many of our projects will be unable to upgrade due to the deprecated use of global Ember in [email protected].

@donaldsonjulia
Copy link

I think it is fair to release a version that drops support for Ember <= 3.16. The sibling addon ember-mobiledoc-editor will almost certainly require dropping support for older Ember versions as part of any attempt to modernize it with Glimmer (but that's a different can of worms 🙂).

@lukemelia
Copy link
Collaborator Author

lukemelia commented Dec 27, 2021

@donaldsonjulia OK, let's make it happen. I think we first need to switch to Github Actions so we can get reasonable feedback during this process. I'll start on that in a separate PR. Update: #75 ✅ Rebased ✅

- Refactor <RenderMobiledoc> component to Glimmer
- Drop ember-wormhole in favor of in-element helper (via ember-in-element-polyfill)
- Drop support for looking up DOM document on old Ember versions
- Update dependencies
- Convert tests to use Glimmer components for cards and atoms
- Drop dependencies on ember-fetch, rsvp and chai
@lukemelia lukemelia changed the title [WIP] Update to use glimmer component [BREAKING] Update to use glimmer component Dec 27, 2021
@lukemelia
Copy link
Collaborator Author

@donaldsonjulia If this PR looks good to you, we can merge and release a beta to try out. LMK.

@donaldsonjulia
Copy link

@lukemelia This looks great to me! I can try out a beta release as soon as it's cut and give feedback.

@lukemelia lukemelia merged commit 1eb0901 into bustle:master Dec 28, 2021
@lukemelia lukemelia deleted the chore/glimmer branch December 28, 2021 17:40
@lukemelia
Copy link
Collaborator Author

Released to NPM as 0.8.0-beta.0

@lukemelia
Copy link
Collaborator Author

@donaldsonjulia did you have a chance to put this release through its paces?

@donaldsonjulia
Copy link

@lukemelia Yes! It is working great so far, no issues at all -- custom cards and atoms are working as expected along with everything else.

@lukemelia
Copy link
Collaborator Author

Thanks! Promoted the beta to 0.8.0 on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants