-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Update to use glimmer component #59
Conversation
I would love to see this get merged if there is clarification on backwards compatibility requirements. Without this update, many of our projects will be unable to upgrade due to the deprecated use of global |
I think it is fair to release a version that drops support for Ember <= 3.16. The sibling addon |
@donaldsonjulia OK, let's make it happen. I think we first need to switch to Github Actions so we can get reasonable feedback during this process. I'll start on that in a separate PR. Update: #75 ✅ Rebased ✅ |
- Refactor <RenderMobiledoc> component to Glimmer - Drop ember-wormhole in favor of in-element helper (via ember-in-element-polyfill) - Drop support for looking up DOM document on old Ember versions - Update dependencies - Convert tests to use Glimmer components for cards and atoms - Drop dependencies on ember-fetch, rsvp and chai
5d6bdba
to
e8c1673
Compare
@donaldsonjulia If this PR looks good to you, we can merge and release a beta to try out. LMK. |
@lukemelia This looks great to me! I can try out a beta release as soon as it's cut and give feedback. |
Released to NPM as 0.8.0-beta.0 |
@donaldsonjulia did you have a chance to put this release through its paces? |
@lukemelia Yes! It is working great so far, no issues at all -- custom cards and atoms are working as expected along with everything else. |
Thanks! Promoted the beta to 0.8.0 on npm. |
Drops support for Ember versions < 3.16
Because compatibility with Ember 4 requires ember-auto-import 2, and addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, we will save this for a separate PR and release.