Provide alternative to inheritance for customizing component paths #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommending inheritance for Glimmer components is not a good practice. This commit adds component arguments to the RenderMobiledoc component that allow a user to achieve the same results via composition. The README is updated accordingly and also converted to use angle bracket syntax in its example code.
lukemelia
force-pushed
the
component-name-hooks
branch
from
388862e to
acf31cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommending inheritance for Glimmer components is not a good practice.
This commit adds component arguments to the RenderMobiledoc component
that allow a user to achieve the same results via composition.
The README is updated accordingly and also converted to use angle
bracket syntax in its example code.