Skip all non-text, non-element nodes in SectionParser

bustle · Jan 28, 2016 · 4d5b4d2 · 4d5b4d2
1 parent 6f5033d
commit 4d5b4d2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/js/parsers/section.js b/src/js/parsers/section.js
@@ -140,9 +140,6 @@ export default class SectionParser {
       case NODE_TYPES.ELEMENT:
         this.parseElementNode(node);
         break;
-      default:
-        assert(`parseNode got unexpected element type ${node.nodeType} ` + node,
-               false);
     }
   }
 

diff --git a/tests/unit/parsers/section-test.js b/tests/unit/parsers/section-test.js
@@ -162,7 +162,7 @@ test('#parse skips STYLE nodes', (assert) => {
   assert.equal(sections.length, 0, 'does not parse style');
 });
 
-test('#parse skips Comment nodes', (assert) => {
+test('#parse skips top-level Comment nodes', (assert) => {
   let element = buildDOM(`
     <!--Some comment-->
   `).firstChild;
@@ -171,3 +171,16 @@ test('#parse skips Comment nodes', (assert) => {
 
   assert.equal(sections.length, 0, 'does not parse comments');
 });
+
+test('#parse skips nested Comment nodes', (assert) => {
+  let element = buildDOM(`
+   <p><!--Some comment-->some text<!-- another comment --></p>
+  `).firstChild;
+  parser = new SectionParser(builder);
+  let sections = parser.parse(element);
+
+  assert.equal(sections.length, 1);
+  let section = sections[0];
+  assert.equal(section.text, 'some text', 'parses text surrounded by comments');
+  assert.equal(section.markers.length, 1, 'only 1 marker');
+});