Consider HOME and END keys as movement keys

fixes #377
bustle · Apr 27, 2016 · c4b2c51 · c4b2c51
1 parent 651bc57
commit c4b2c51
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/js/utils/key.js b/src/js/utils/key.js
@@ -95,7 +95,7 @@ const Key = class Key {
   }
 
   isMovement() {
-    return this.isArrow();
+    return this.isArrow() || this.isHome() || this.isEnd();
   }
 
   isArrow() {
@@ -120,6 +120,14 @@ const Key = class Key {
     return this.keyCode === Keycodes.RIGHT;
   }
 
+  isHome() {
+    return this.keyCode === Keycodes.HOME;
+  }
+
+  isEnd() {
+    return this.keyCode === Keycodes.END;
+  }
+
   get direction() {
     switch (true) {
       case this.isDelete():

diff --git a/tests/unit/utils/key-test.js b/tests/unit/utils/key-test.js
@@ -50,3 +50,23 @@ test('firefox arrow keypress is not printable', (assert) => {
   let key = Key.fromEvent(event);
   assert.ok(!key.isPrintable());
 });
+
+test('HOME key is movement', (assert) => {
+  let element = $('#qunit-fixture')[0];
+  let event = Helpers.dom.createMockEvent('keypress', element, {
+    keyCode: Keycodes.HOME,
+    charCode: 0
+  });
+  let key = Key.fromEvent(event);
+  assert.ok(key.isMovement());
+});
+
+test('END key is movement', (assert) => {
+  let element = $('#qunit-fixture')[0];
+  let event = Helpers.dom.createMockEvent('keypress', element, {
+    keyCode: Keycodes.END,
+    charCode: 0
+  });
+  let key = Key.fromEvent(event);
+  assert.ok(key.isMovement());
+});