Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link command 98 #106

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Fix link command 98 #106

merged 1 commit into from
Sep 1, 2015

Conversation

bantic
Copy link
Collaborator

@bantic bantic commented Sep 1, 2015

fixes #98

Changes the link command to use postEditor. This PR:

  • removes the last usages of document.execCommand
  • removes a lot of now-unnecessary selection-related methods in "selection-utils"
  • refactors several of the views to catch some memory leak and to use a more consistent class hierarchy

@bantic bantic force-pushed the fix-link-command-98 branch from 28e5114 to dcab0ad Compare September 1, 2015 19:31
bantic added a commit that referenced this pull request Sep 1, 2015
@bantic
Merge pull request #106 from bustlelabs/fix-link-command-98
a6659ef 
Fix link command 98
@bantic bantic merged commit a6659ef into master Sep 1, 2015
@bantic bantic deleted the fix-link-command-98 branch September 1, 2015 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typing in link causes console error
1 participant
@bantic