Event listeners #18
Merged
Event listeners #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,14 @@ | |||
| export default class EventListenerMixin { | |||
There was a problem hiding this comment.
Why not keep mixins as pain objects? Used this way, the prototype is basically just a bag for the mixin properties. An object would be sufficient.
|
Very cool, but needs a rebase. We should really nuke utils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
EventListenermixin that is mixed into the base View class, the Editor, and the ToolbarButton. It adds anaddEventListenermethod that keeps track of added listeners so that the mixed-inremoveAllEventListenersmethod can be called later.