Editor section tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let startTextNode = walkDOMUntil(containingStartElement, findTextNode(startText)); | ||
| let endTextNode = walkDOMUntil(containingEndElement, findTextNode(endText)); | ||
| if (!startTextNode) { throw new Error(`Could not find textNode containing "${startText}"`); } | ||
| if (!endTextNode) { throw new Error(`Could not find textNode containing "${endText}"`); } |
bantic
force-pushed
the
editor-section-tests
branch
2 times, most recently
from
cf59b72 to
a067a4f
Compare
|
This is ready to go now. There is still a single failing FF test, but it is due to the way Firefox implements |
bantic
force-pushed
the
editor-section-tests
branch
2 times, most recently
from
34e49d1 to
b0e28cc
Compare
* Tests for typing "\r\n" to create section, deleting sections * Refactor selectText to take optional start/end, more deletion tests * add helper `skipInPhantom` * test that when highlighting bold text, the bold button is active * Do not turn stickyToolbar on by default (this breaks Phantom tests) * remove extra `setTimeout` in mouseup listener
bantic
force-pushed
the
editor-section-tests
branch
from
b0e28cc to
dafdee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that typing enter (
"\r\n") in a section breaks it into two, and that selecting text across sections and deleting merges them into one.Tests pass in:
FF(will be fixed later)Ready to merge