Add better guard against inserting item from other list into linked list #251
+154
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this._adoptItem) { this._adoptItem(item); } | ||
| } | ||
| freeItem(item) { | ||
| item[PARENT_PROP] = null; | ||
| item.prev = null; | ||
| item.next = null; |
There was a problem hiding this comment.
Shouldn't this already be done by remove?
There was a problem hiding this comment.
Ah you've moved it. As prev and next are related to position and not ownerships (adopt/free) IMO the changes should be made in remove. For example adopt does not set a prev or next.
There was a problem hiding this comment.
Makes sense. I've moved it. Thanks for looking it over.
|
👍 |
Adds `__parent` property to items to identify their inclusion in a list. This allows us to always know when we are inserting an item from another list. The previous heuristic (checking for presence of `next` and `prev`) is not correct in all scenarios, leading to unusual bugs. This refactors `insertBefore` method slightly for clarity, and simplifies `remove` because we now know for sure when we are removing an item in this list. Adds some additional test coverage.
bantic
added a commit
that referenced
this pull request
Dec 2, 2015
Add better guard against inserting item from other list into linked list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
__parentproperty to items to identify their inclusion in a list.This allows us to always know when we are inserting an item from another
list. The previous heuristic (checking for presence of
nextandprev) isnot correct in all scenarios, leading to unusual bugs.
This refactors
insertBeforemethod slightly for clarity, andsimplifies
removebecause we now know for sure when we are removingan item in this list.
Adds some additional test coverage.