Always setRange in toggleMarkup and toggleSection
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,6 +63,10 @@ const Position = class Position { | |||
| return this.markerPosition.offset; | |||
| } | |||
|
|
|||
| get isBlank() { | |||
| return false; | |||
There was a problem hiding this comment.
Why not a property set inside the constructor?
There was a problem hiding this comment.
No particular reason; I can change it. FWIW I don't think that defining a getter using get X() versus setting it on this in the constructor changes the shape of the object, in case that is a concern. I'll put it in the constructor for clarity, though.
This helps prevent a situation where the editor element has a selection but it is not the active element. Typing while another element (like a button) is focused (active) but the editor element has the selection is problematic: The browser refocuses on the editor element and starts inserting text, but it handles the input before it has focused, which means the key* handlers do not fire. Also renamed Position#emptyPosition and Range#emptyRange -> blankPosition, blankRange. Adds `isBlank` property to Position and Range. Defensively avoid attempting to render a cursor when the range is blank. When cursor contains non-markerable, toggleMarkup is no-op Fixes #285 Fixes #287
bantic
force-pushed
the
fix-toggle-section-marker-285
branch
from
d777d7d to
5ae07ee
Compare
mixonic
added a commit
that referenced
this pull request
Jan 11, 2016
Always `setRange` in `toggleMarkup` and `toggleSection`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps prevent a situation where the editor element has a selection
but it is not the active element. Typing while another element (like a
button) is focused (active) but the editor element has the selection is
problematic: The browser refocuses on the editor element and starts
inserting text, but it handles the input before it has focused, which
means the key* handlers do not fire.
blankPosition, blankRange. Adds
isBlankproperty to Position andRange.
splitMarkerAtOffsetto Section base class (fixes "section.splitMarkerAtOffset is not a function" when card is selected andtoggleMarkercalled #287)cc @mixonic
Fixes #285