Refactor cursor positioning #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously possible to create a position with a null section or an invalid section (like a list section). A position must have a section that the cursor can be rendered at; this PR adds an assertion to that fact. Before this change, if the window.getSelection() pointed at the editor's element, Position#fromNode would naively assume that the post's first section at offset 0 was the position, but this creates an invalid position when the first section is a list section. * add Post#headPosition and #tailPosition * add Section#isSection property * Refactor Position#fromNode * tests for Position#fromNode for text nodes, element nodes, card-related nodes * Position constructor asserts it has a valid leaft section and offset
|
🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously possible to create a position with a null section or
an invalid section (like a list section). A position must have a section
that the cursor can be rendered at; this PR adds an assertion to that
fact.
Before this change, if the window.getSelection() pointed at the editor's
element, Position#fromNode would naively assume that the post's first
section at offset 0 was the position, but this creates an invalid
position when the first section is a list section.
This tightens up some of the cursor positioning and adds a bunch of tests for
Position#fromNodein various scenarios.