Constrain selection to editor element when probing for range #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toggle-editable button, error display, selection display, special styles for when editing is disabled.
This fixes an issue where `Position.fromNode` would be called with a node that is outside the editor element, triggering a failed assertion. Now, Cursor constrains the selection to only include the extent inside the editor element before looking up Positions from the anchor and focus nodes. Most of the time this situation is prevented by the browser (it refuses to allow one to create a selection that crosses into or out of the contentEditable div), but when `editor.disableEditing()` is called, a user can triple-click the last part of the mobiledoc document which causes the browser (for Chrome and Safari, but not Firefox) to extend the selection *outside* the editor's element. Fixes #486 as reported by @YoranBrondsema
bantic
force-pushed
the
fix-triple-selection-486
branch
from
996f3cf to
63142e5
Compare
Closed
|
released in v0.10.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
Position.fromNodewould be called with a nodethat is outside the editor element, triggering a failed assertion.
Now, Cursor constrains the selection to only include the extent inside the
editor element before looking up Positions from the anchor and focus nodes.
Most of the time this situation is prevented by the browser (it refuses to
allow one to create a selection that crosses into or out of the
contentEditable div), but when
editor.disableEditing()is called, a usercan triple-click the last part of the mobiledoc document which causes the
browser (for Chrome and Safari, but not Firefox) to extend the selection
outside the editor's element.
Fixes #486 as reported by @YoranBrondsema