WIP - Initial pass to get attributes in the right location #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@mixonic I added the markup section modifier attributes to the 0.3.1 parser/renderer as well as the editor dom for now. What is the policy on updating/backporting the other versions of the parser/rendere? |
rondale-sc
force-pushed
the
center-justify
branch
from
4b1c6f5 to
a78afd0
Compare
This sets up the: - PostNodeBuilder - to pass the attributes through to the MarkupSection constructor - 031 Renderer - so that we can properly serialize the mobiledoc attributes on the section - 031 Parser - so we can take the above serialized mobiledoc representation and parse it back into a mobiledoc post - editor-dom - So that we can actually do something with the attribute information It also adds an `_attributable` function that adds our attribute stuff here. This will also likely be used inside list sections so that we can also center lists made outside of markup. The test with the `debugger` statements in it utilizes all of the above. At this point we need to: - Make the section element (in editor dom) actually encode `data-md-text-align` into an appropriate inline style attribute. - Update the DOM / Text Renderer - Flesh out the test some more - And verify the rest of the build passes
This was referenced May 7, 2019
|
I'm closing this in favor of #682 - I've used this work as a starting point though and it was helpful path-finding! Thanks @rondale-sc 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.