Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed range#expandByMarker not expanding to beginning/end of section #677

Merged
merged 3 commits into from
May 7, 2019
Merged

🐛 Fixed range#expandByMarker not expanding to beginning/end of section #677

merged 3 commits into from
May 7, 2019

Conversation

kevinansfield
Copy link
Collaborator

@kevinansfield kevinansfield commented Apr 29, 2019 •
edited
Loading

closes #676

  • after failing to find a non-matching marker, perform a check for the first/last markers in the range's section matching the supplied detection callback. If it does match we can assume that we checked all markers in that direction so we expand to the beginning/end of the section
  • improves behaviour to match the documentation: "expand a range to all markers matching a given check"

@kevinansfield kevinansfield requested a review from mixonic April 29, 2019 13:43
@kevinansfield
Fixed range#expandByMarker not expanding to beginning/end of section
e850675 
closes bustle#676
- after failing to find a non-matching marker, perform a check for the first/last markers in the range's section matching the supplied detection callback. If it does match we can assume that we checked all markers in that direction so we expand to the beginning/end of the section
- improves behaviour to match the documentation: "expand a range to all markers matching a given check"
@kevinansfield kevinansfield changed the title Fixed range#expandByMarker not expanding to beginning/end of section 🐛 Fixed range#expandByMarker not expanding to beginning/end of section May 3, 2019
mixonic
mixonic approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinansfield minor changes requested, should be no-ops. This seems reasonable. It is a public API change, I'll at least bump the pre-1.0 minor version.

mixonic and others added 2 commits May 7, 2019 10:06
@kevinansfield
Copy link
Collaborator Author

@mixonic requested changes reviewed and committed 👍

@mixonic mixonic merged commit 0000d1d into bustle:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

range#expandByMarker will not expand to the beginning of the section
2 participants
@kevinansfield @mixonic