Add disableEditing, enableEditing #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
disable-editing
branch
from
910e44f to
6c988b5
Compare
|
@bantic could use a review here! |
| @@ -167,6 +167,20 @@ test('hitting enter at end of a section creates new empty section', (assert) => | |||
| offset: 0}); | |||
| }); | |||
|
|
|||
| Helpers.skipInPhantom('deleting across 0 sections does nothing if editing is disabled', (assert) => { | |||
There was a problem hiding this comment.
this should be safe to run in phantom, and should say "delete across 2 sections"
|
@mixonic 👍 I had a small comment on one of the tests. It would be nice if there were a single bottleneck that event listeners ran through — that way there'd only be a single point where you would ignore events — like a |
mixonic
force-pushed
the
disable-editing
branch
2 times, most recently
from
6b78e81 to
931e868
Compare
|
Phantom does not respect toggling |
mixonic
force-pushed
the
disable-editing
branch
from
931e868 to
22f723f
Compare
mixonic
added a commit
that referenced
this pull request
Aug 24, 2015
Add disableEditing, enableEditing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the 0.4.0 epic, we would like an API for disabling the ability for a user to enter and edit existing text. This is useful in conjunction with the programmatic API- It allows us to build editing interfaces that output mobiledoc and cards, but without needing to allow freeform content.
The APIs are:
editor.disableEditing()- stop the user from being able to edit thecurrent post with their cursor. Programmatic edits are still allowed.
editor.enableEditing()- allow the user to make direct edits directlyto a post's text.