Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update For All Translations #1198

Closed
Kennybll opened this issue Dec 14, 2017 · 2 comments
Closed

Update For All Translations #1198

Kennybll opened this issue Dec 14, 2017 · 2 comments

Comments

@Kennybll
Copy link
Contributor

Kennybll commented Dec 14, 2017 •
edited
Loading

Expected behavior

We have 51 translation files under /src/client/locales/*.json. But on Settings.js and translations/index.js there is support for 40 of the translation files.

Actual behavior

We should have support for all 51 files.

How to reproduce

Look at the links above, and count.

  • Browser: Chrome
  • Operating system: Windows 10
@Kennybll Kennybll mentioned this issue Dec 15, 2017
Closed
@Sekhmet
Copy link
Contributor

Sekhmet commented Dec 15, 2017

I don't think we should enable incomplete translations. Seeing only 40% of page translated would be annoying.

@Sekhmet
Copy link
Contributor

Sekhmet commented Dec 23, 2017

We will only make complete (usable) translations available to users.

@Sekhmet Sekhmet closed this as completed Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sekhmet @Kennybll @bonustrack