Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old CLI --dir arg clobbers new CLI --dir argument #7415

Closed
ydnar opened this issue Oct 30, 2023 · 2 comments
Closed

old CLI --dir arg clobbers new CLI --dir argument #7415

ydnar opened this issue Oct 30, 2023 · 2 comments
Labels
bug Incorrect behavior in the current implementation that needs fixing

Comments

@ydnar
Copy link

ydnar commented Oct 30, 2023

Thanks for releasing the compatibility shim in v14.0.3! I ran into an odd compatibility issue:

If wasmtime is run without WASMTIME_NEW_CLI=1, then --dir is always interpreted as a single value, and not HOST::GUEST:

wasmtime run --dir ./::./ ...

Fails with:

Error: failed to open directory './::./'
@ydnar ydnar added the bug Incorrect behavior in the current implementation that needs fixing label Oct 30, 2023
@alexcrichton
Copy link
Member

Thanks for the report, I've opened #7416 to fix the warning here and we can do a 14.0.4 release as well in a day or two to collect some more feedback.

I'll also confirm though that Wasmtime doesn't just fail with the error message above, it also prints the expected warning about the old-vs-new CLI, which is what I at least expected. Still something that's worth fixing because otherwise --dir-with-remapping behavior isn't actually able to be used without a warning or env var, which isn't great.

@alexcrichton
Copy link
Member

Fixed in #7416, backported in #7421, and 14.0.4 will go out when #7431 is merged, so closing. Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants