From dbcacfa94d367a3cd47cb6f0a3430569715f194b Mon Sep 17 00:00:00 2001 From: Samuel Audet Date: Mon, 28 Jun 2021 10:03:04 +0900 Subject: [PATCH] * Fix compatibility with Gradle 7.x (issue #17) --- CHANGELOG.md | 1 + build.gradle | 4 ++-- samples/zlib/build.gradle | 4 ++-- src/main/java/org/bytedeco/gradle/javacpp/BuildExtension.java | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96fa189..cbf3cf1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ + * Fix compatibility with Gradle 7.x ([issue #17](https://github.com/bytedeco/gradle-javacpp/issues/17)) * Make `BuildTask` properties `public` to allow access with Kotlin DSL ([pull #16](https://github.com/bytedeco/gradle-javacpp/issues/16)) * Fix `BuildPlugin` incorrectly resetting `javacppBuildParser.outputDirectory` in subprojects ([pull #12](https://github.com/bytedeco/gradle-javacpp/issues/12)) diff --git a/build.gradle b/build.gradle index 3da6281..9d33dc2 100644 --- a/build.gradle +++ b/build.gradle @@ -38,10 +38,10 @@ jar { manifest { attributes 'Implementation-Title': 'Gradle JavaCPP', 'Implementation-Vendor': 'Bytedeco', - 'Implementation-Version': version, + 'Implementation-Version': project.version, 'Specification-Title': 'Gradle JavaCPP', 'Specification-Vendor': 'Bytedeco', - 'Specification-Version': version + 'Specification-Version': project.version } } diff --git a/samples/zlib/build.gradle b/samples/zlib/build.gradle index 0a5d368..4ad56da 100644 --- a/samples/zlib/build.gradle +++ b/samples/zlib/build.gradle @@ -59,10 +59,10 @@ jar { attributes 'Class-Path': configurations.runtimeClasspath.collect { it.getName() }.join(' '), 'Implementation-Title': 'JavaCPP Presets for zlib', 'Implementation-Vendor': 'Bytedeco', - 'Implementation-Version': version, + 'Implementation-Version': project.version, 'Specification-Title': 'JavaCPP Presets for zlib', 'Specification-Vendor': 'Bytedeco', - 'Specification-Version': version + 'Specification-Version': project.version } } diff --git a/src/main/java/org/bytedeco/gradle/javacpp/BuildExtension.java b/src/main/java/org/bytedeco/gradle/javacpp/BuildExtension.java index c8469b1..2eb8085 100644 --- a/src/main/java/org/bytedeco/gradle/javacpp/BuildExtension.java +++ b/src/main/java/org/bytedeco/gradle/javacpp/BuildExtension.java @@ -72,7 +72,7 @@ public BuildExtension(BuildPlugin plugin) { public List existingArtifacts(Configuration configuration) throws IOException { ArrayList artifacts = new ArrayList(); BasePluginConvention bc = project.getConvention().getPlugin(BasePluginConvention.class); - File libsDir = bc.getLibsDir(); + File libsDir = new File(project.getBuildDir(), bc.getLibsDirName()); libsDir.mkdirs(); try { // Temporarily rename our project to prevent Gradle from resolving the artifacts to project dependencies without files.